fixed SampledImage::sample() fns being unnecessarily marked as unsafe #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
changed the title
eddyb
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Context for what went wrong here: in bc2a121
(intermediary state during the original Image PR #359), the S method-level parameter was replaced with the Image "sampled type" (which, crucially, didn't exist initially in the Image PR #359).
But the signature change wasn't accompanied by removing the then-inaccurate safety aspects (the UB only ever stemmed from the OpTypeImage "Sampled Type" and that S parameter being able to differ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be a forgotten leftover from a refactor in #359
EDIT(@eddyb): removed quoted Discord messages (referring to bc2a121) in favor of PR comments (see below)